fix: paginate PR file fetch for scoring accuracy#274
Open
taooutsider wants to merge 11 commits intoentrius:testfrom
Open
fix: paginate PR file fetch for scoring accuracy#274taooutsider wants to merge 11 commits intoentrius:testfrom
taooutsider wants to merge 11 commits intoentrius:testfrom
Conversation
…ntrius#238) Co-authored-by: bittoby <bittoby@users.noreply.github.com> Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com>
…a_web_agents_subnet (entrius#251) Co-authored-by: Nicknamess96 <113626193+Nicknamess96@users.noreply.github.com> Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com> Co-authored-by: BitToby <218712309+bittoby@users.noreply.github.com> Co-authored-by: bittoby <bittoby@users.noreply.github.com> Co-authored-by: Muhammet Eren Karakuş <erenkar950@gmail.com>
…epo (entrius#256) Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com>
Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com>
Co-authored-by: anderdc <alexanderdcastaneda@gmail.com>
Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com>
Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com>
Author
|
This fix prevents truncated PR file lists when changed files > 30 (GitHub default), which can under-score larger contributions. Happy to adjust if you prefer Link-header based pagination. |
Collaborator
|
please fix conflicts, will not review until then |
anderdc
force-pushed
the
test
branch
3 times, most recently
from
bcd7b1f to
4e74e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /repos/{owner}/{repo}/pulls/{number}/filesusingper_page=100+pageWhy
GitHub returns only 30 files by default for PR file listings. For PRs with many changed files, scoring could miss file diffs and undercount contribution value.
Changes
get_pull_request_file_changes()to fetch all pagesValidation
pytest -q tests/utils/test_github_api_tools.py -k FileChangesRetryLogic10 passed